forked from nusCS2113-AY1819S1/addressbook-level3
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement update password feature #98
Merged
ShreyasKp
merged 11 commits into
CS2113-AY1819S1-F10-3:master
from
iamputradanish:master
Oct 11, 2018
Merged
Implement update password feature #98
ShreyasKp
merged 11 commits into
CS2113-AY1819S1-F10-3:master
from
iamputradanish:master
Oct 11, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
iamputradanish
added
type.epic
A big feature which can be broken down into smaller stories e.g. search
priority.high
Must do
labels
Oct 11, 2018
iamputradanish
requested review from
andyrobert3,
ShreyasKp,
muhdharun and
ongweekeong
October 11, 2018 10:42
ShreyasKp
approved these changes
Oct 11, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good implementation of password feature. However, do refactor and try to follow OOPs concepts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
priority.high
Must do
type.epic
A big feature which can be broken down into smaller stories e.g. search
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update password only works for HQP.
command: "update password"
Will refactor in future versions
Currently,
HQP password: mama123
PO password: johnny456